ci: regenerate models against current master to avoid duplicate PRs#861
Merged
Conversation
The regeneration used to build on top of a possibly stale existing update-models-docs-pr-N branch. When the same spec change had already been merged into master through another route (e.g. a manually merged client PR), re-regenerating on the stale base re-emitted that change as a fresh diff and opened a PR duplicating what master already had. Now the job regenerates on the master checkout, skips entirely when the result is identical to master, and otherwise force-points the branch at master before committing a single regenerated commit on top — so the diff is always relative to current master. The PR still updates on every new commit to the source docs PR.
vdusek
added
the
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #861 +/- ##
==========================================
+ Coverage 94.49% 94.51% +0.01%
==========================================
Files 48 48
Lines 5069 5069
==========================================
+ Hits 4790 4791 +1
+ Misses 279 278 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Regenerate modelsworkflow opened #860, duplicating webhook fields already merged via #855. The Set up branch step regenerated on top of a staleupdate-models-docs-pr-<N>branch (based on a pre-#855master), so an already-merged change reappeared as a fresh diff.Fix: always regenerate against the current
master.masterand skips when there is no diff, so an already-merged change can no longer produce a duplicate PR.masterandsigned-commitadds one regenerated commit on top. The PR still updates whenever the source docs PR gets new commits.Trade-off: the branch is always a single regenerated commit on top of
master, so any commits pushed onto it directly are replaced on the next run. This is the intended, idempotent behavior for an auto-generated branch.